sql_lab: re-raise exception in get_sql_results #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2017
xrmx
force-pushed
the
reraisesqllabgetresults
branch
from
eabd057
to
4f3c658
Compare
|
Coverage decreased (-0.01%) to 69.259% when pulling 4f3c658e3662bf798866c4a10d83407ca0e56153 on xrmx:reraisesqllabgetresults into d7e4191 on apache:master. |
|
@mistercrunch could you please merge this? We have two open bugs and one closed that are affected by this. |
xrmx
force-pushed
the
reraisesqllabgetresults
branch
from
4f3c658
to
14867b9
Compare
|
Coverage decreased (-0.09%) to 69.295% when pulling 14867b9574dc9e3c933a68e0028ef45de61dc91d on xrmx:reraisesqllabgetresults into 6045063 on apache:master. |
As caller expect it to raise an exception instead of returning None. Refs apache#3075
xrmx
force-pushed
the
reraisesqllabgetresults
branch
from
14867b9
to
f4250b4
Compare
3 similar comments
| @@ -98,6 +98,7 @@ def get_sql_results( | |||
| query.status = QueryStatus.FAILED | |||
| query.tmp_table_name = None | |||
| sesh.commit() | |||
| raise | |||
There was a problem hiding this comment.
I think this should be raise e
There was a problem hiding this comment.
If it's not passed to raise it's the one in the scope. I've verified it with both python3 and python2.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As caller expect it to raise an exception instead of returning
None. Haven't run this but tests pass.
Refs #3075